src/lib/Libutil/pbs_ical.c no longer builds with newer versions of libical
Description
Building PBS Pro with libical version 3.0.3 produces the following compile error:
1
2
3
4
5
6
7
8
../../../../src/lib/Libutil/pbs_ical.c: In function 'get_num_occurrences':
../../../../src/lib/Libutil/pbs_ical.c:129:10: warning: implicit declaration of function 'icaltime_from_timet'; did you mean 'icaltime_as_timet'? [-Wimplicit-function-declaration]
start = icaltime_from_timet(dtstart, 0);
^~~~~~~~~~~~~~~~~~~
icaltime_as_timet
../../../../src/lib/Libutil/pbs_ical.c:129:8: error: incompatible types when assigning to type 'struct icaltimetype' from type 'int'
start = icaltime_from_timet(dtstart, 0);
^The function icaltime_from_timet() had been deprecated for a while and has been removed now. The recommended fix is to replace all occurrences of
icaltime_from_timet(..., ...) with icaltime_from_timet_with_zone(..., ..., NULL).
Affected Platforms:
openSUSE Tumbleweed, openSUSE Factory
Acceptance Criteria
Make PBS Pro sources build against recent versions of libical (tested 3.0.3).
(Patch proposal attached).
Status
Assignee
Unassigned
Reporter
Egbert Eich
Severity
None
OS
None
Start Date
None
Pull Request URL
None
Story Points
1
Components
Affects versions
18.1.1
Priority
LowConfigure