PBS Server can potentially crash in some or all platforms due to linker not getting suitable return types

Description

PBS Server can potentially crash in some or all platforms due to linker not getting the expected return values for the functions given below called inside server. In the absence of fixing these we may nor may not be seeing the issue at present but we can definitely get PBS server crashes in future and hence fixing them is mandatory.

req_delete.c: In function ‘req_deletejob’:
req_delete.c:347:2: warning: implicit declaration of function ‘chk_job_request’ [-Wimplicit-function-declaration]
parent = chk_job_request(jid, preq, &jt);
^
req_delete.c:347:9: warning: assignment makes pointer from integer without a cast [enabled by default]
parent = chk_job_request(jid, preq, &jt);

req_message.c: In function ‘req_messagejob’:
req_message.c:96:12: warning: assignment makes pointer from integer without a cast [enabled by default]
if ((pjob = chk_job_request(preq->rq_ind.rq_message.rq_jid, preq, &jt)) == 0)
^
req_message.c: In function ‘req_py_spawn’:
req_message.c:193:7: warning: assignment makes pointer from integer without a cast [enabled by default]
pjob = chk_job_request(jid, preq, &jt);

req_message.c: In function ‘req_relnodesjob’:
req_message.c:289:7: warning: assignment makes pointer from integer without a cast [enabled by default]
pjob = chk_job_request(jid, preq, &jt);

req_delete.c: In function ‘remove_stagein’:
req_delete.c:134:7: warning: assignment makes pointer from integer without a cast [enabled by default]
preq = cpy_stage(preq, pjob, JOB_ATR_stagein, 0);

req_delete.c: In function ‘req_deleteReservation’:
req_delete.c:862:8: warning: assignment makes pointer from integer without a cast [enabled by default]
presv = chk_rescResv_request(preq->rq_ind.rq_delete.rq_objname, preq);

req_delete.c:134:7: warning: assignment makes pointer from integer without a cast [enabled by default]
preq = cpy_stage(preq, pjob, JOB_ATR_stagein, 0);
^
req_delete.c: In function ‘req_deleteReservation’:
req_delete.c:862:8: warning: assignment makes pointer from integer without a cast [enabled by default]
presv = chk_rescResv_request(preq->rq_ind.rq_delete.rq_objname, preq);

Acceptance Criteria

None

Status

Assignee

Unassigned

Reporter

Suresh Thelkar

Severity

3-High

OS

None

Start Date

None

Pull Request URL

None

Story Points

1

Components

Priority

High